Skip to content

chore: contributing-information #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

ryanbas21
Copy link
Contributor

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-3970

Description

Add and align the contributing documentation with other platforms

Copy link

changeset-bot bot commented May 21, 2025

⚠️ No Changeset found

Latest commit: bddcc1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented May 21, 2025

View your CI Pipeline Execution ↗ for commit 5005c75.

Command Status Duration Result
nx affected -t build lint test docs e2e-ci --ve... ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check --verbose ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-27 21:18:55 UTC

@ryanbas21 ryanbas21 force-pushed the contributing-information branch from 0339720 to d8259f9 Compare May 22, 2025 13:06
@ryanbas21 ryanbas21 force-pushed the contributing-information branch from d8259f9 to fa4fe24 Compare May 22, 2025 13:10

## Standards of Practice

We ask that all contributors to this project adhere to our engineering Standard for team culture, practices and code of conduct. We expect everyone to be respectful, inclusive, and collaborative. Any violations will be handled according to the project's guidelines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we provide a link to these standards/guidelines?

Copy link

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes look good, left two suggested changes to be reviewed

@ryanbas21 ryanbas21 force-pushed the contributing-information branch from fa4fe24 to bddcc1c Compare May 27, 2025 19:01
@ryanbas21 ryanbas21 force-pushed the contributing-information branch from bddcc1c to 5005c75 Compare May 27, 2025 21:17
Copy link

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me

@ryanbas21 ryanbas21 merged commit 3d6308f into develop May 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants